Fixes #405. Adds integration tests to asciidoctorj-distribution. #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Real tests FTW! |
robertpanzer
added a commit
that referenced
this pull request
Nov 23, 2015
Fixes #405. Adds integration tests to asciidoctorj-distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#401 has shown that JRuby behaves differently when loading gems from a jar or from an exploded directory.
The current test cases for diagram and pdf only refer to the exploded gems which does not reflect the way gems are loaded by a user, i.e. "in production".
I added a test case to asciidoctorj-distribution that creates a ditaa diagram, very similar to the test in asciidoctorj-diagram.
But as asciidoctorj-diagram is referenced as a dependency, the gem will be loaded from a jar.
#401 can be reproduced with this PR when setting the JRuby version to 1.7.22.