Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for the distribution #405

Closed
robertpanzer opened this issue Nov 4, 2015 · 2 comments
Closed

Add integration tests for the distribution #405

robertpanzer opened this issue Nov 4, 2015 · 2 comments
Labels
enhancement

Comments

@robertpanzer
Copy link
Member

Apparently JRuby behaves differently when loading gems that are exploded in the file system or when they are packaged in a jar.
The current unit tests test the pdf converter and the diagram extension only with exploded gems.

Tests should be added that render a PDF and diagrams using the jars built by asciidoctorj-diagram and asciidoctorj-pdf.
@mojavelinux
Copy link
Member

Apparently JRuby behaves differently when loading gems that are exploded in the file system or when they are packaged in a jar.

That doesn't surprise me.

Tests should be added that render a PDF and diagrams using the jars built by asciidoctorj-diagram and asciidoctorj-pdf.

Definitely.

robertpanzer added a commit to robertpanzer/asciidoctorj that referenced this issue Nov 20, 2015
@robertpanzer
Fixes asciidoctor#405. Adds integration tests to asciidoctorj-distrib…
527ab90 
…ution.
robertpanzer added a commit that referenced this issue Nov 23, 2015
@robertpanzer
Merge pull request #410 from robertpanzer/integration-test
49a78bf 
Fixes #405. Adds integration tests to asciidoctorj-distribution.
@robertpanzer
Copy link
Member Author

Fixed with #405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mojavelinux @robertpanzer