Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add plantuml.include.path support to kroki PlantUML preprocessor #222

Closed
anb0s opened this issue Feb 16, 2021 · 0 comments · Fixed by #223
Closed

add plantuml.include.path support to kroki PlantUML preprocessor #222

anb0s opened this issue Feb 16, 2021 · 0 comments · Fixed by #223
Labels
🍩 enhancement New feature or request

Comments

@anb0s
Copy link
Contributor

anb0s commented Feb 16, 2021 •
edited
Loading

Follow up from: #201 (comment)

We need support of property plantuml.include.path for the kroki PlantUML preprocessor.

Proposed name: kroki-plantuml-include-paths , e.g.:
:kroki-plantuml-include-paths: "~/diagrams/styles"

Multiple paths can be defined with path separator : (Unix) or ; (Windows) , e.g.:
:kroki-plantuml-include-paths: "~/diagrams/styles:~/diagrams/library"

Relative paths should be resolved with current document base directory.
anb0s added a commit to anb0s/asciidoctor-kroki that referenced this issue Feb 16, 2021
@anb0s
add plantuml.include.path support to kroki PlantUML proprocessor
b291279 
fixes asciidoctor#222
@anb0s anb0s mentioned this issue Feb 16, 2021
Merged
anb0s added a commit to anb0s/asciidoctor-kroki that referenced this issue Feb 16, 2021
@anb0s
add plantuml.include.path support to kroki PlantUML proprocessor
5a66735 
fixes asciidoctor#222
anb0s added a commit to anb0s/asciidoctor-kroki that referenced this issue Feb 16, 2021
@anb0s
add plantuml.include.path support to kroki PlantUML proprocessor
1c19579 
fixes asciidoctor#222
anb0s added a commit to anb0s/asciidoctor-kroki that referenced this issue Feb 16, 2021
@anb0s
add plantuml.include.path support to kroki PlantUML proprocessor
1e2a1d0 
fixes asciidoctor#222
anb0s added a commit to anb0s/asciidoctor-kroki that referenced this issue Feb 16, 2021
@anb0s
add plantuml.include.path support to kroki PlantUML preprocessor
55d1857 
fixes asciidoctor#222
@anb0s anb0s changed the title add plantuml.include.path support to kroki PlantUML proprocessor add plantuml.include.path support to kroki PlantUML preprocessor Feb 16, 2021
anb0s added a commit to anb0s/asciidoctor-kroki that referenced this issue Feb 16, 2021
@anb0s
add kroki-plantuml-include-paths attribute for PlantUML preprocessor
7018e79 
fixes asciidoctor#222
@ggrossetie ggrossetie added the 🍩 enhancement New feature or request label Feb 17, 2021
anb0s added a commit to anb0s/asciidoctor-kroki that referenced this issue Feb 17, 2021
@anb0s
add kroki-plantuml-include-paths attribute for PlantUML preprocessor
257b9a3 
fixes asciidoctor#222
anb0s added a commit to anb0s/asciidoctor-kroki that referenced this issue Feb 22, 2021
@anb0s
add kroki-plantuml-include-paths attribute for PlantUML preprocessor
c0499df 
fixes asciidoctor#222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍩 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add kroki-plantuml-include-paths attribute for PlantUML preprocessor anb0s/asciidoctor-kroki
2 participants
@anb0s @ggrossetie