-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve relative PlantUML includes from the diagram directory (not from the Asciidoctor base directory) #201
Comments
I vote for this issue! I experiencing difficulties with multi-file & multi-directory documentation project. As the consequences we have:
|
The plantuml preprocessor here use definition like supported in PlantUML via parameter plantuml.include.path and implicitly set it to I think this can be changed to have the implicit behaviour like |
…om the Asciidoctor base directory) fixes asciidoctor#201
Let's take an example:
docs/index.adoc
docs/diagrams/hello.puml
docs/diagrams/style.puml
Currently, the extension won't resolve
style.puml
because the path is resolved from the base directory.In the above example the resolved path will be
docs/style.puml
instead ofdocs/diagrams/style.puml
.Implementation-wise, the last parameter should be the diagram directory and not the base directory:
https://github.com/Mogztter/asciidoctor-kroki/blob/1372acb3bad3cad143fcbab5a7c8aaa5f802cfb7/src/asciidoctor-kroki.js#L76
This issue is a follow-up of: #191 (where we did this change for Vega diagrams)
The text was updated successfully, but these errors were encountered: