Fix revset parentheses #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why I'm getting lint errors? I didn't touch that file 🤔 |
|
Thanks for this! FWIW this looks good to me. I like how thorough the tests are! I have nothing to add about the spurious clippy warnings. I'm getting identical warnings in #545 but only in CI. Clippy appears to be happy when I run it locally. 😕 |
|
I think it may be caused by a recent rust upgrade; I wasn't getting it locally either and then I upgraded rust and started seeing it locally as well |
|
I believe #561 should fix it |
arxanas
force-pushed
the
pokey/fix-revset-parentheses
branch
from
7ab65cb
to
09c366c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parentheses anywhere in revsets
Fixes #558