Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint error #561

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Fix lint error #561

merged 1 commit into from
Sep 24, 2022

Conversation

pokey
Copy link
Collaborator

@pokey pokey commented Sep 23, 2022

I believe this is what was intended. I think the linter caught a genuine error here, because I believe 0 actually would refer to commit here. At least that's what the linter suggests would be equivalent. Guessing maybe the map gets sorted alphabetically, so then 0 would refer to commit?

Looks like there's no tests for this error message, though, as the tests passed whether I put {commit} or {source} here

@pokey pokey mentioned this pull request Sep 23, 2022
@arxanas
Copy link
Owner

arxanas commented Sep 24, 2022

Thanks! Not sure why this wasn't caught in CI previously.

@arxanas arxanas merged commit a0cd598 into arxanas:master Sep 24, 2022
@pokey
Copy link
Collaborator Author

pokey commented Sep 24, 2022

I think it may be caused by a recent rust upgrade; I wasn't getting it locally either and then I upgraded rust and started seeing it locally as well

@pokey pokey deleted the pokey/fix-lint-error branch September 24, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants