Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode function to Continuous class #650

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

rohanbabbar04
Copy link
Collaborator

Description

  • Should cover up remaining distributions in Continuous which don't have an analytical expression

Checklist

  • Code style is correct (follows ruff and black guidelines)
  • Includes new or updated tests to cover the new feature

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26%. Comparing base (f25da81) to head (f797bf0).
Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   82.23%   74.26%   -7.97%     
==========================================
  Files         101      105       +4     
  Lines        8020     8774     +754     
==========================================
- Hits         6595     6516      -79     
- Misses       1425     2258     +833     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aloctavodia
Copy link
Contributor

We can merge, but I would like to manually check this is producing sensible results. Can you list the distributions I should check?

@rohanbabbar04
Copy link
Collaborator Author

These are the 4 distributions:

  • ExGaussian
  • Rice
  • SkewStudentT
  • SkewNormal

@aloctavodia
Copy link
Contributor

Thanks!

@aloctavodia aloctavodia merged commit d7ed83a into arviz-devs:main Feb 22, 2025
4 checks passed
@rohanbabbar04 rohanbabbar04 deleted the mode_continuous branch February 22, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants