Skip to content

Commit

Permalink
Add mode function to Continuous class (#650)
Browse files Browse the repository at this point in the history
  • Loading branch information
rohanbabbar04 authored Feb 22, 2025
1 parent 9bd36b9 commit d7ed83a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
5 changes: 4 additions & 1 deletion preliz/distributions/distributions.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import numpy as np

from preliz.internal.distribution_helper import init_vals, valid_distribution, valid_scalar_params
from preliz.internal.optimization import optimize_hdi
from preliz.internal.optimization import find_mode, optimize_hdi
from preliz.internal.plot_helper import (
check_inside_notebook,
get_slider,
Expand Down Expand Up @@ -795,6 +795,9 @@ def __init__(self):
super().__init__()
self.kind = "continuous"

def mode(self):
return find_mode(self)


class Discrete(Distribution):
"""Base class for discrete distributions."""
Expand Down
5 changes: 1 addition & 4 deletions preliz/distributions/rice.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from preliz.distributions.distributions import Continuous
from preliz.internal.distribution_helper import all_not_none, eps
from preliz.internal.optimization import find_mode, optimize_ml, optimize_moments_rice
from preliz.internal.optimization import optimize_ml, optimize_moments_rice
from preliz.internal.special import cdf_bounds, ppf_bounds_cont


Expand Down Expand Up @@ -129,9 +129,6 @@ def entropy(self):
def mean(self):
return self.sigma * np.sqrt(np.pi / 2) * _l_half(-(self.nu**2) / (2 * self.sigma**2))

def mode(self):
return find_mode(self)

def median(self):
return self.ppf(0.5)

Expand Down

0 comments on commit d7ed83a

Please sign in to comment.