Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trigger property to protected #95

Closed
wants to merge 1 commit into from
Closed

feat: trigger property to protected #95

wants to merge 1 commit into from

Conversation

wengeezhang
Copy link
Collaborator

No description provided.

@noahziheng noahziheng requested a review from hyj1991 June 6, 2022 03:21
@noahziheng
Copy link
Member

LGTM
@wengeezhang TriggerStructure 这个名字不太符合项目中的使用方法，而且也不太容易显示它是个 Interface，个人建议有两个稍好点的法子：

  • 用 TriggerInterface 代替，虽然也没有类似用法，但能达意，说明它是个 Interface
  • 效仿其他几个功能类的做法，以 Trigger 作为 Interface 名，现有实现更名为 ArtusTrigger
    • 可能有 Breaking Change，cc @hyj1991

@noahziheng noahziheng force-pushed the feat/trigger_protect branch from 5d3a0b9 to 3c0cb64 Compare June 6, 2022 03:22
@noahziheng noahziheng mentioned this pull request Jun 6, 2022
Merged
@noahziheng
Copy link
Member

duplicate #94

@noahziheng noahziheng closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyj1991 hyj1991 Awaiting requested review from hyj1991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wengeezhang @noahziheng