Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: open trigger extend #94

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

JerrysShan
Copy link
Collaborator

No description provided.

@JerrysShan JerrysShan changed the title chore: open trigger extend WIP: chore: open trigger extend Jun 1, 2022
@JerrysShan JerrysShan changed the title WIP: chore: open trigger extend chore: open trigger extend Jun 1, 2022
src/types.ts Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/trigger/index.ts Show resolved Hide resolved
@noahziheng noahziheng force-pushed the ssk/chore/application branch from 72f550b to dd4e01b Compare June 15, 2022 08:56
@hyj1991
Copy link
Member

hyj1991 commented Jun 15, 2022

PR 最好描述下改动的目的和改动的大概设计,review 光看代码有时候不能很好理解

@hyj1991
Copy link
Member

hyj1991 commented Jun 23, 2022

@noahziheng 看下你这边还有未解决的 comment

@noahziheng noahziheng merged commit 5d82d3b into artusjs:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants