Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): prevent require.resolve paths arguments undefined #231

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

noahziheng
Copy link
Member

@noahziheng noahziheng commented Feb 21, 2023

related #229

1.0.4 版本可能造成使用预先生成的 manifest 文件时,因为缺少扫描器补入的 baseDir(对 package 字段意义不大)造成 require.resolve 失败

image

代码很早之前就在,之前未触发的主要原因是:

  • Scanner 之前基于避免非必要合并的考虑,剔除了 plugin-config loader 的全部 item,所以确实 loaderState.baseDir 的 item 不会进入运行时的 loader
  • 重构期间为了对齐所有 config 的合并逻辑,移除了剔除 item 的代码

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Base: 92.76% // Head: 92.76% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (67742ad) compared to base (c86b7b5).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          54       54           
  Lines        1299     1300    +1     
  Branches      225      225           
=======================================
+ Hits         1205     1206    +1     
  Misses         94       94           
Impacted Files Coverage Δ
src/plugin/factory.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hyj1991 hyj1991 merged commit 5ece688 into artusjs:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants