Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(loader): format plugin config in factory && support inline package #229

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

noahziheng
Copy link
Member

@noahziheng noahziheng commented Feb 14, 2023

resolve #228

主要改动:

  • 移除 PluginConfigLoader,统一由 ConfigLoader 处理
  • 移除扫描器最终对 plugin-config 的无意义过滤逻辑,manifest 中将继续包括 plugin 相关配置
  • ConfigLoader 针对 plugin 使用新增的 PluginFactory.formatPluginConfig 进行 packagepath 的解析/格式化
  • path 字段支持内连 npm 包获取入口
  • 单测调整

注:Framework 因为机制有待讨论,暂未修改 cc @JerrysShan

src/plugin/common.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Base: 92.60% // Head: 92.76% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (66eb9c9) compared to base (1157c23).
Patch coverage: 97.29% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   92.60%   92.76%   +0.15%     
==========================================
  Files          55       54       -1     
  Lines        1298     1299       +1     
  Branches      218      225       +7     
==========================================
+ Hits         1202     1205       +3     
+ Misses         96       94       -2     
Impacted Files Coverage Δ
src/constant.ts 100.00% <ø> (ø)
src/loader/impl/index.ts 100.00% <ø> (ø)
src/scanner/scan.ts 95.27% <ø> (-0.07%) ⬇️
src/plugin/common.ts 97.61% <92.85%> (-2.39%) ⬇️
src/loader/impl/config.ts 90.24% <100.00%> (+0.50%) ⬆️
src/plugin/factory.ts 100.00% <100.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@noahziheng noahziheng self-assigned this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

framework和plugin配置里关于 path 信息处理的问题
4 participants