Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scanner): filter config with env #155

Merged

Conversation

noahziheng
Copy link
Member

resolve #154

临时方案,暂时解决 BUG,后续需对 Scanner 进行重构,理清递归过程

@noahziheng noahziheng changed the title feat(scanner): filter config with env WIP: feat(scanner): filter config with env Jul 29, 2022
@noahziheng noahziheng force-pushed the feat/scanner-filter-config-with-env branch from 5c307c0 to 1addba3 Compare July 29, 2022 05:46
@noahziheng noahziheng changed the title WIP: feat(scanner): filter config with env feat(scanner): filter config with env Jul 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #155 (1addba3) into master (d9d5ee2) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   88.82%   88.93%   +0.11%     
==========================================
  Files          50       51       +1     
  Lines        1083     1094      +11     
  Branches      174      177       +3     
==========================================
+ Hits          962      973      +11     
  Misses        121      121              
Impacted Files Coverage Δ
src/loader/impl/config.ts 88.88% <100.00%> (-1.81%) ⬇️
src/loader/impl/framework_config.ts 100.00% <100.00%> (ø)
src/loader/impl/plugin_config.ts 92.30% <100.00%> (+0.30%) ⬆️
src/loader/utils/config_file_meta.ts 100.00% <100.00%> (ø)
src/scanner/scan.ts 94.85% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d5ee2...1addba3. Read the comment docs.

@noahziheng noahziheng merged commit a0acead into artusjs:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 多环境 Config 合并不正确(v1.0.0-alpha.16)
4 participants