Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 多环境 Config 合并不正确(v1.0.0-alpha.16) #154

Closed
noahziheng opened this issue Jul 29, 2022 · 1 comment · Fixed by #155
Closed

[BUG] 多环境 Config 合并不正确(v1.0.0-alpha.16) #154

noahziheng opened this issue Jul 29, 2022 · 1 comment · Fixed by #155
Assignees
@noahziheng
Labels
bug Something isn't working

Comments

@noahziheng
Copy link
Member

现象

运行时 env 设定失效

成因

#131 调整配置合并逻辑为运行时 Object.assign 所有配置文件，这一行为基于 Manifest 中应只包括自身环境的配置文件，Scanner 中对此估计不足，现时实现不具备这一效果，导致运行时将全部 Config 合并，造成配置项混乱
@noahziheng noahziheng added the bug Something isn't working label Jul 29, 2022
@noahziheng noahziheng self-assigned this Jul 29, 2022
@hyj1991
Copy link
Member

hyj1991 commented Jul 29, 2022

启动期其实没有 env 的概念了，因为 Scanner 扫出来所有 env 下的 manifest，交给启动期的是确定 env 下对应的 manifest，所以这里的合并并没有问题，当时我有个 comment

@noahziheng noahziheng mentioned this issue Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahziheng noahziheng

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(scanner): filter config with env noahziheng/core
2 participants
@noahziheng @hyj1991