Fix SIP type identification (#79) #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 59.79% 60.14% +0.34%
==========================================
Files 29 29
Lines 1965 1982 +17
==========================================
+ Hits 1175 1192 +17
+ Misses 697 696 -1
- Partials 93 94 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
mcantelon
force-pushed
the
dev/sip-identify
branch
3 times, most recently
from
288f53e to
7b024c6
Compare
|
PR to fix/update the SIP type identification: #84 |
jraddaoui
approved these changes
Nov 18, 2024
internal/activities/transform_sip.go
Outdated
| @@ -38,8 +38,8 @@ func (a *TransformSIP) Execute(ctx context.Context, params *TransformSIPParams) | |||
|
|
|||
| // Move the Prozess_Digitalisierung_PREMIS.xml file to the PIP metadata | |||
| // directory. Prozess_Digitalisierung_PREMIS.xml is only present in | |||
| // digitized SIPs, and there can only be one dossier in a digitized SIP. | |||
| if params.SIP.Type == enums.SIPTypeDigitizedSIP { | |||
| // digitized SIPs/AIPs, and there can only be one dossier in a digitized SIP. | |||
mcantelon
force-pushed
the
dev/sip-identify
branch
from
7b024c6 to
bb34504
Compare
Fixed and updated SIP type identification logic and updated related tests.
mcantelon
force-pushed
the
dev/sip-identify
branch
from
bb34504 to
5d924d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and updated SIP type identification logic and updated related tests.