-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: Born Digital AIPs are not being identified correctly #79
Labels
Comments
mcantelon
added a commit
that referenced
this issue
Nov 17, 2024
Fixed and updated SIP type identification logic and updated related tests.
mcantelon
added a commit
that referenced
this issue
Nov 18, 2024
Fixed and updated SIP type identification logic and updated related tests.
mcantelon
added a commit
that referenced
this issue
Nov 18, 2024
Fixed and updated SIP type identification logic and updated related tests.
mcantelon
added a commit
that referenced
this issue
Nov 18, 2024
Fixed and updated SIP type identification logic and updated related tests.
PR merged. |
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The Identify SIP structure activity is currently identifying three types of transfers:
BornDigital
,DigitizedSIP
, andDigitizedAIP
. However, there should be four - the two Digitized types as well asBornDigitalSIP
andBornDigitalAIP
. I think in a previous issue I failed to properly differentiate between the two different types of AIP - apologies. Right now, the activity is identifying all AIPs as DigitizedAIP.To Reproduce
Steps to reproduce the behavior:
Identify SIP structure
- the result will beSIP structure identified: DigitizedAIP
Expected behavior
A born digital SIP should be identified as
BornDigitalSIP
(this is just a name change to the existingBornDigital
). A born digital AIP should be identified asBornDigitalAIP
The criteria for all four types is as follows:
BornDigitalSIP
- this is the base type; assume this is the type unless other conditions are metDigitizedSIP
- contains Prozess_Digitalisierung_PREMIS.xml file, DOES NOT contain additional directoryBornDigitalAIP
- contains additional directory, DOES NOT contain Prozess_Digitalisierung_PREMIS.xml fileDigitizedAIP
- contains additional directory AND contains Prozess_Digitalisierung_PREMIS.xml fileScreenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: