Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Born Digital AIPs are not being identified correctly #79

Closed
sallain opened this issue Nov 7, 2024 · 2 comments
Closed

Problem: Born Digital AIPs are not being identified correctly #79

sallain opened this issue Nov 7, 2024 · 2 comments
Assignees

Comments

@sallain
Copy link
Contributor

sallain commented Nov 7, 2024

Describe the bug

The Identify SIP structure activity is currently identifying three types of transfers: BornDigital, DigitizedSIP, and DigitizedAIP. However, there should be four - the two Digitized types as well as BornDigitalSIP and BornDigitalAIP. I think in a previous issue I failed to properly differentiate between the two different types of AIP - apologies. Right now, the activity is identifying all AIPs as DigitizedAIP.

To Reproduce

Steps to reproduce the behavior:

  1. Upload a born digital AIP (e.g. 1-Test-AIP-Files.zip or 2-Test-AIP-GEVER.zip)
  2. Review the output for the task Identify SIP structure - the result will be SIP structure identified: DigitizedAIP

Expected behavior

A born digital SIP should be identified as BornDigitalSIP (this is just a name change to the existing BornDigital). A born digital AIP should be identified as BornDigitalAIP

The criteria for all four types is as follows:

  • BornDigitalSIP - this is the base type; assume this is the type unless other conditions are met
  • DigitizedSIP - contains Prozess_Digitalisierung_PREMIS.xml file, DOES NOT contain additional directory
  • BornDigitalAIP - contains additional directory, DOES NOT contain Prozess_Digitalisierung_PREMIS.xml file
  • DigitizedAIP - contains additional directory AND contains Prozess_Digitalisierung_PREMIS.xml file

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

@sallain sallain added this to Enduro Nov 7, 2024
@sallain sallain moved this to 👍 Ready in Enduro Nov 7, 2024
@jraddaoui jraddaoui self-assigned this Nov 12, 2024
@fiver-watson fiver-watson assigned mcantelon and unassigned jraddaoui Nov 12, 2024
mcantelon added a commit that referenced this issue Nov 17, 2024
Fixed and updated SIP type identification logic and updated related
tests.
mcantelon added a commit that referenced this issue Nov 18, 2024
Fixed and updated SIP type identification logic and updated related
tests.
mcantelon added a commit that referenced this issue Nov 18, 2024
Fixed and updated SIP type identification logic and updated related
tests.
mcantelon added a commit that referenced this issue Nov 18, 2024
Fixed and updated SIP type identification logic and updated related
tests.
@mcantelon
Copy link
Contributor

PR merged.

@sallain
Copy link
Contributor Author

sallain commented Nov 20, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants