Don't rename Prozess_Digitalisierung_PREMIS.xml #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 54.06% 53.85% -0.21%
==========================================
Files 29 29
Lines 2090 2087 -3
==========================================
- Hits 1130 1124 -6
- Misses 891 893 +2
- Partials 69 70 +1 ☔ View full report in Codecov by Sentry. |
jraddaoui
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Nice @djjuhasz, thanks!
We also need to change it in the premis package: https://github.com/artefactual-sdps/preprocessing-sfa/blob/main/internal/premis/premis.go#L380-L384.
djjuhasz
force-pushed
the
dev/issue-58-stop-appending-premis-suffix
branch
from
519e0ef to
a43ff55
Compare
Fixes #58 Digitized (Vecteur) SIPs are the only type of SIP that contain a Prozess_Digitalisierung_PREMIS.xml file, and they will only ever contain a single dossier. Because digitized SIPs only have a single dossier that contains a single Prozess_Digitalisierung_PREMIS.xml file there's no need to rename the file in the PIP to avoid name clashes. Changes: - Update the SIP identification logic - if a SIP has a Prozess_Digitalisierung_PREMIS.xml file then it must be a digitized SIP - Add a SIP validation check to confirm that digitized SIPs only contain a single dossier - Remove the SIP transformation code that renamed the Prozess_Digitalisierung_PREMIS.xml file
djjuhasz
force-pushed
the
dev/issue-58-stop-appending-premis-suffix
branch
from
4729f7d to
bc5d806
Compare
jraddaoui
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
Digitized (Vecteur) SIPs are the only type of SIP that contain a Prozess_Digitalisierung_PREMIS.xml file, and they will only ever contain a single dossier. Because digitized SIPs only have a single dossier that contains a single Prozess_Digitalisierung_PREMIS.xml file there's no need to rename the file in the PIP to avoid name clashes.
Changes: