Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Prozess_Digitalisierung_PREMIS.xml should not append the parent directory name when moved to the metadata folder #58

Closed
jraddaoui opened this issue Sep 24, 2024 · 2 comments · Fixed by #67
Closed

Problem: Prozess_Digitalisierung_PREMIS.xml should not append the parent directory name when moved to the metadata folder #58

jraddaoui opened this issue Sep 24, 2024 · 2 comments · Fixed by #67
Assignees
@djjuhasz
Labels
Client: SFA SFA bridge work

Comments

@jraddaoui
Copy link
Contributor

Describe the bug

We thought it would be possible to include multiple dossiers in the same digitized SIP and appended the parent directory (dossier) name to avoid file name conflicts in the metadata directory.

To Reproduce

Ingest a digitized SIP type that includes a Prozess_Digitalisierung_PREMIS.xml file.

Expected behavior

Prozess_Digitalisierung_PREMIS.xml should be moved as it is to the metadata directory.
@jraddaoui jraddaoui added this to Enduro Sep 24, 2024
@jraddaoui jraddaoui moved this to 👍 Ready in Enduro Sep 24, 2024
@jraddaoui
Copy link
Contributor Author

Parent directory name is appended in:

https://github.com/artefactual-sdps/preprocessing-sfa/blob/main/internal/activities/transform_sip.go#L46-L55

It's also checked in:

https://github.com/artefactual-sdps/preprocessing-sfa/blob/main/internal/pips/pips.go#L46-L51
https://github.com/artefactual-sdps/preprocessing-sfa/blob/main/internal/premis/premis.go#L380-L384

@djjuhasz djjuhasz self-assigned this Oct 21, 2024
@djjuhasz djjuhasz moved this from 👍 Ready to ⏳ In Progress in Enduro Oct 21, 2024
djjuhasz added a commit that referenced this issue Oct 21, 2024
@djjuhasz
Don't rename Prozess_Digitalisierung_PREMIS.xml
519e0ef 
Fixes #58

Digitized (Vecteur) SIPs are the only type of SIP that contain a
Prozess_Digitalisierung_PREMIS.xml file, and they will only ever
contain a single dossier.  Because digitized SIPs only have a single
dossier that contains a single Prozess_Digitalisierung_PREMIS.xml file
there's no need to rename the file in the PIP to avoid name clashes.

Changes:
- Update the SIP identification logic - if a SIP has a
  Prozess_Digitalisierung_PREMIS.xml file then it must be a digitized
  SIP
- Add a SIP validation check to confirm that digitized SIPs only contain
  a single dossier
- Remove the SIP transformation code that renamed the
  Prozess_Digitalisierung_PREMIS.xml file
@djjuhasz djjuhasz mentioned this issue Oct 21, 2024
Merged
@djjuhasz djjuhasz linked a pull request Oct 21, 2024 that will close this issue
Don't rename Prozess_Digitalisierung_PREMIS.xml #67
Merged
djjuhasz added a commit that referenced this issue Oct 22, 2024
@djjuhasz
Don't rename Prozess_Digitalisierung_PREMIS.xml
a43ff55 
Fixes #58

Digitized (Vecteur) SIPs are the only type of SIP that contain a
Prozess_Digitalisierung_PREMIS.xml file, and they will only ever
contain a single dossier.  Because digitized SIPs only have a single
dossier that contains a single Prozess_Digitalisierung_PREMIS.xml file
there's no need to rename the file in the PIP to avoid name clashes.

Changes:
- Update the SIP identification logic - if a SIP has a
  Prozess_Digitalisierung_PREMIS.xml file then it must be a digitized
  SIP
- Add a SIP validation check to confirm that digitized SIPs only contain
  a single dossier
- Remove the SIP transformation code that renamed the
  Prozess_Digitalisierung_PREMIS.xml file
djjuhasz added a commit that referenced this issue Oct 23, 2024
@djjuhasz
Don't rename Prozess_Digitalisierung_PREMIS.xml
bc5d806 
Fixes #58

Digitized (Vecteur) SIPs are the only type of SIP that contain a
Prozess_Digitalisierung_PREMIS.xml file, and they will only ever
contain a single dossier.  Because digitized SIPs only have a single
dossier that contains a single Prozess_Digitalisierung_PREMIS.xml file
there's no need to rename the file in the PIP to avoid name clashes.

Changes:
- Update the SIP identification logic - if a SIP has a
  Prozess_Digitalisierung_PREMIS.xml file then it must be a digitized
  SIP
- Add a SIP validation check to confirm that digitized SIPs only contain
  a single dossier
- Remove the SIP transformation code that renamed the
  Prozess_Digitalisierung_PREMIS.xml file
djjuhasz added a commit that referenced this issue Oct 24, 2024
@djjuhasz
Don't rename Prozess_Digitalisierung_PREMIS.xml
de095ea 
Fixes #58

Digitized (Vecteur) SIPs are the only type of SIP that contain a
Prozess_Digitalisierung_PREMIS.xml file, and they will only ever
contain a single dossier.  Because digitized SIPs only have a single
dossier that contains a single Prozess_Digitalisierung_PREMIS.xml file
there's no need to rename the file in the PIP to avoid name clashes.

Changes:
- Update the SIP identification logic - if a SIP has a
  Prozess_Digitalisierung_PREMIS.xml file then it must be a digitized
  SIP
- Add a SIP validation check to confirm that digitized SIPs only contain
  a single dossier
- Remove the SIP transformation code that renamed the
  Prozess_Digitalisierung_PREMIS.xml file
@github-project-automation github-project-automation bot moved this from ⏳ In Progress to 🎉 Done in Enduro Oct 24, 2024
@sallain
Copy link
Contributor

sallain commented Oct 30, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djjuhasz djjuhasz

Labels
Client: SFA SFA bridge work
Projects
Enduro
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't rename Prozess_Digitalisierung_PREMIS.xml artefactual-sdps/preprocessing-sfa
3 participants
@djjuhasz @jraddaoui @sallain