Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: migration packages will now contain a logical metadata file #98

Closed
sallain opened this issue Dec 4, 2024 · 1 comment · Fixed by #101
Closed

Problem: migration packages will now contain a logical metadata file #98

sallain opened this issue Dec 4, 2024 · 1 comment · Fixed by #101
Assignees

Comments

@sallain
Copy link
Contributor

sallain commented Dec 4, 2024

Describe the bug

The migration packages will include an extra metadata file going forward (the logical metadata extracted from Preservica). SFA would like there to be a check to confirm that the file has been included in the package, that it is valid, and then move it to the metadata directory. This affects the BornDigitalAIP and DigitizedAIP transfer types.

Expected behavior

Some activity (could re-use the Validate SIP structure activity) will look for a file located at package-name/data/additional/package-name-premis.xml. The activity will confirm that the file is present and that the name of the file preceding -premis.xml matches the name of the package.

Another activity (perhaps Validate SIP metadata or Validate PREMIS) will validate the above listed file. It should be valid PREMIS. The output for the activity should indicate that this PREMIS file has been validated.

Finally, the file should be moved to the metadata directory during the Restructure SIP activity.

I will provide sample packages once the structure is confirmed by SFA.

Additional context

See #97 for more information about the new package structure.

@sallain sallain added this to Enduro Dec 4, 2024
@sallain sallain moved this to 🛠 Refining in Enduro Dec 4, 2024
@sallain sallain changed the title WIP ISSUE Problem: need to confirm that migration packages contain logical metadata file WIP ISSUE Problem: migration packages will now contain a logical metadata file Dec 4, 2024
@sallain sallain changed the title WIP ISSUE Problem: migration packages will now contain a logical metadata file Problem: migration packages will now contain a logical metadata file Dec 5, 2024
@sallain sallain moved this from 🛠 Refining to 👍 Ready in Enduro Dec 5, 2024
@djjuhasz djjuhasz self-assigned this Dec 13, 2024
@djjuhasz djjuhasz moved this from 👍 Ready to ⏳ In Progress in Enduro Dec 13, 2024
djjuhasz added a commit that referenced this issue Dec 16, 2024
Add an activity to validate the logical metadata PREMIS XML file against
a local copy of the PREMIS v3 XSD.

Setps;
- Verify that an SFA AIP includes a logical metadata file
- Create a local PREMIS v3 XSD file for validating the logical metadata
  file
- Validate the logical metadata file against the PREMIS v3 XSD
djjuhasz added a commit that referenced this issue Dec 17, 2024
Add an activity to validate the logical metadata PREMIS XML file against
a local copy of the PREMIS v3 XSD.

Setps;
- Verify that an SFA AIP includes a logical metadata file
- Create a local PREMIS v3 XSD file for validating the logical metadata
  file
- Validate the logical metadata file against the PREMIS v3 XSD
djjuhasz added a commit that referenced this issue Dec 17, 2024
Refs #98

Add the logical metadata file to the expected SIP structure for the AIP
SIP types. Update activities related to SIP structure: identify SIP,
validate files, validate structure, and verify manifest.
djjuhasz added a commit that referenced this issue Dec 17, 2024
Refs #98.

Add an activity to validate the logical metadata PREMIS XML file against
a local copy of the PREMIS v3 XSD. To avoid downloading the PREMIS XSD
every time the activity runs I've embedded a local copy of the XSD in
the worker Go binary, and write the contents to a file on disk so it can
be loaded by xmllint.
djjuhasz added a commit that referenced this issue Dec 17, 2024
Refs #98.

Move the logical metadata file to the metadata directory when
transforming the SIP.
djjuhasz added a commit that referenced this issue Dec 17, 2024
Refs #98.

Add an activity to validate the logical metadata PREMIS XML file against
a local copy of the PREMIS v3 XSD. To avoid downloading the PREMIS XSD
every time the activity runs I've embedded a local copy of the XSD in
the worker Go binary, and write the contents to a file on disk so it can
be loaded by xmllint.
djjuhasz added a commit that referenced this issue Dec 17, 2024
Refs #98.

Move the logical metadata file to the metadata directory when
transforming the SIP.
djjuhasz added a commit that referenced this issue Dec 17, 2024
Refs #98.

Add an activity to validate the logical metadata PREMIS XML file against
a local copy of the PREMIS v3 XSD. To avoid downloading the PREMIS XSD
every time the activity runs I've embedded a local copy of the XSD in
the worker Go binary, and write the contents to a file on disk so it can
be loaded by xmllint.
djjuhasz added a commit that referenced this issue Dec 17, 2024
Refs #98.

Move the logical metadata file to the metadata directory when
transforming the SIP.
@djjuhasz djjuhasz linked a pull request Dec 17, 2024 that will close this issue
djjuhasz added a commit that referenced this issue Dec 18, 2024
Refs #98.

Add an activity to validate the logical metadata PREMIS XML file against
a local copy of the PREMIS v3 XSD. To avoid downloading the PREMIS XSD
every time the activity runs I've embedded a local copy of the XSD in
the worker Go binary, and write the contents to a file on disk so it can
be loaded by xmllint.
djjuhasz added a commit that referenced this issue Dec 18, 2024
Refs #98.

Move the logical metadata file to the metadata directory when
transforming the SIP.
djjuhasz added a commit that referenced this issue Dec 18, 2024
Refs #98

Add the logical metadata file to the expected SIP structure for the AIP
SIP types. Update activities related to SIP structure: identify SIP,
validate files, validate structure, and verify manifest.
djjuhasz added a commit that referenced this issue Dec 18, 2024
Refs #98.

Add an activity to validate the logical metadata PREMIS XML file against
a local copy of the PREMIS v3 XSD. To avoid downloading the PREMIS XSD
every time the activity runs I've embedded a local copy of the XSD in
the worker Go binary, and write the contents to a file on disk so it can
be loaded by xmllint.
djjuhasz added a commit that referenced this issue Dec 18, 2024
Refs #98.

Move the logical metadata file to the metadata directory when
transforming the SIP.
@github-project-automation github-project-automation bot moved this from ⏳ In Progress to 🎉 Done in Enduro Dec 18, 2024
@djjuhasz djjuhasz moved this from 🎉 Done to 🧐 QA in Enduro Dec 19, 2024
@sallain
Copy link
Contributor Author

sallain commented Jan 8, 2025

LGTM! I see the error reported in two places:

Image

This is good, since SFA wants to have all preprocessing errors reported at once.

A bag WITH the logical metadata file succeeds as expected:

Image

I also confirmed that this only applies to SIPs identified as DigitizedAIP and BornDigitalAIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

2 participants