Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Born Digital AIPs fail with a "verify manifest" error #90

Closed
djjuhasz opened this issue Nov 27, 2024 · 1 comment · Fixed by #91
Closed

Problem: Born Digital AIPs fail with a "verify manifest" error #90

djjuhasz opened this issue Nov 27, 2024 · 1 comment · Fixed by #91
Assignees
@djjuhasz
Labels
bug Something isn't working Client: SFA

Comments

@djjuhasz
Copy link
Contributor

Describe the bug

When a born digital AIP is sent to preprocessing (e.g. 1-Test-AIP-Files.zip) the validate structure activity fails returns the following validation errors:

"Failures": [
      "XSD folder is missing",
      "metadata.xml is missing",
      "Unexpected directory: \"Test-AIP-Files/additional\""
]

And the verify manifest activity returns the following error:

"verify manifest: parse manifest: open: open /home/preprocessing/shared/Test-AIP-Files/header/metadata.xml: no such file or directory"

To Reproduce

Steps to reproduce the behavior:

  1. Upload the attached AIP to Enduro, with the preprocessing-sfa child workflow active
  2. The above errors occur and processing fails

Expected behavior

The SIP should validate and be sent to preservation successfully.

Screenshots

image

Additional context

The SIP structure set in https://github.com/artefactual-sdps/preprocessing-sfa/blob/main/internal/sip/sip.go#L95 is using the same Manifest and Metadata paths as the bornDigitalSIP(), but I believe it should use the digitizedAIP() paths instead.
@djjuhasz djjuhasz added Client: SFA bug Something isn't working labels Nov 27, 2024
@djjuhasz djjuhasz self-assigned this Nov 27, 2024
@scollazo scollazo added this to Enduro Nov 27, 2024
@sallain sallain moved this to 👍 Ready in Enduro Nov 27, 2024
@djjuhasz djjuhasz moved this from 👍 Ready to ⏳ In Progress in Enduro Nov 27, 2024
djjuhasz added a commit that referenced this issue Nov 27, 2024
@djjuhasz
Fix handling of born-digital AIPs, fixes #90
a5e4382 
- Update expected SIP paths for born-digital AIPs to include
  "additional/UpdatedAreldaMetadata.xml" and "content/header/old/SIP/
  metadata.xml" files
- Update verify_manifest activity to handle born-digital AIP manifests
  correctly
- Add tests for all SFA SIP types
@djjuhasz djjuhasz linked a pull request Nov 27, 2024 that will close this issue
Fix handling of born-digital AIPs, fixes #90 #91
Merged
djjuhasz added a commit that referenced this issue Nov 28, 2024
@djjuhasz
Fix handling of born-digital AIPs, fixes #90
451bb29 
- Update expected SIP paths for born-digital AIPs to include
  "additional/UpdatedAreldaMetadata.xml" and "content/header/old/SIP/
  metadata.xml" files
- Update verify_manifest activity to handle born-digital AIP manifests
  correctly
- Add tests for all SFA SIP types
@github-project-automation github-project-automation bot moved this from ⏳ In Progress to 🎉 Done in Enduro Nov 28, 2024
@djjuhasz djjuhasz moved this from 🎉 Done to 🧐 QA in Enduro Nov 28, 2024
@sallain
Copy link
Contributor

sallain commented Jan 8, 2025

This seems to be fixed. The SIP is identified as BornDigitalAIP and the SIP structure is valid.

Note that I had to update the test package with a logical metadata file to comply with work done in #98.

@sallain sallain moved this from 🧐 QA to 🎉 Done in Enduro Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djjuhasz djjuhasz

Labels
bug Something isn't working Client: SFA
Projects
Enduro
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of born-digital AIPs, fixes #90 artefactual-sdps/preprocessing-sfa
2 participants
@djjuhasz @sallain