Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize watcher Download() interface #868

Merged
merged 1 commit into from
Mar 1, 2024

Standardize the watcher Download() interface

21095e5
Select commit
Loading
Failed to load commit list.
Merged

Standardize watcher Download() interface #868

Standardize the watcher Download() interface
21095e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 1, 2024 in 0s

47.23% (+1.23%) compared to e23712e

View this Pull Request on Codecov

47.23% (+1.23%) compared to e23712e

Details

Codecov Report

Attention: Patch coverage is 67.18750% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 47.23%. Comparing base (e23712e) to head (21095e5).

Files Patch % Lines
internal/watcher/minio.go 55.55% 4 Missing and 4 partials ⚠️
internal/watcher/filesystem.go 78.78% 4 Missing and 3 partials ⚠️
internal/filenotify/filenotify.go 50.00% 2 Missing ⚠️
internal/filenotify/poller.go 0.00% 2 Missing ⚠️
internal/watcher/watcher.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   45.99%   47.23%   +1.23%     
==========================================
  Files          94       94              
  Lines        5061     5087      +26     
==========================================
+ Hits         2328     2403      +75     
+ Misses       2531     2462      -69     
- Partials      202      222      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov