Standardize watcher Download() interface #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djjuhasz
added a commit
that referenced
this pull request
Feb 23, 2024
Fixes #868 - Update existing watcher Download() method and interface signatures to take a destination filepath (string) instead of an io.Writer stream - Add a `filewatcher.Download()` method - Create a `minio.Download()` method and move implementation specific code from `serviceImpl.Download()` to it - Update mocks
djjuhasz
force-pushed
the
dev/issue-867-standardize-watcher-download
branch
2 times, most recently
from
9cb1f5e to
0a39488
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 45.99% 47.23% +1.23%
==========================================
Files 94 94
Lines 5061 5087 +26
==========================================
+ Hits 2328 2403 +75
+ Misses 2531 2462 -69
- Partials 202 222 +20 ☔ View full report in Codecov by Sentry. |
djjuhasz
force-pushed
the
dev/issue-867-standardize-watcher-download
branch
2 times, most recently
from
696bb2e to
0478086
Compare
|
@djjuhasz I think that you're environment is somehow still using an old version of mockgen. Using bash: Not sure what's going on. Maybe you're using a version of mockgen installed globally, but that shouldn't happen afaik. You could try this: That would force mockgen to be downloaded again when running: |
|
@sevein I forgot to do the |
djjuhasz
force-pushed
the
dev/issue-867-standardize-watcher-download
branch
from
faef6e3 to
72b2994
Compare
djjuhasz
force-pushed
the
dev/issue-867-standardize-watcher-download
branch
6 times, most recently
from
e934211 to
983284e
Compare
Refs #867 - Update the existing watcher `Download()` method and interface signatures to take a destination filepath (string) instead of an `io.Writer` stream - Add a `filewatcher.Download()` method - Create a `minio.Download()` method and move implementation specific code from `serviceImpl.Download()` to it - Add `MinioConfig.URL` field to set bucket config by URL for testing - Add unit tests - Update mocks
djjuhasz
force-pushed
the
dev/issue-867-standardize-watcher-download
branch
from
983284e to
21095e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #867
filewatcher.Download()methodminio.Download()method and move implementation specific code fromserviceImpl.Download()to it