Revert lazy init #844
Closed
Revert lazy init #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade Firebase to 5.7.0 and prune frameworks
Adding basic best practice info to Contribution Guidelines
Updating install script to make necessary build changes to enable Cra…
|
@briantq looks like you've merged all changes from v2 into v1 with this PR. I was expecting to only merge the lazy-init changes (i.e. PR #832) so that v1 worked as it did in v1.0.5 and earlier. I would expect this to be the last change we need to make to v1. If people want new features or bug fixes, they can adopt v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making PR to merge into v1