Updating install script to make necessary build changes to enable Cra… #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One note, I tried to make the change in after_prepare, but for some reason the xcode project would not update. I also tried in before_prepare but still had the same problem. Therefore, I went back to add_plugin which does work. |
soumak77
approved these changes
Sep 10, 2018
|
@soumak77 Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…shlytics on iOS
I believe this should be sufficient for enabling Crashlytics on iOS, specifically adding the build phase mentioned in the Fabric guide, https://firebase.google.com/docs/crashlytics/get-started#ios
To test this, remove and install the plugin via
cordova plugin add https://github.com/briantq/cordova-plugin-firebase.git#enable-crashlytics-ios. Ensure there is a Crashlytics build task.Note, without PR #832, you will still need to manually initialize Crashlytics to test Crashlytics properly.