Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Publisher Everywhere #3803

Merged
merged 7 commits into from
Jul 22, 2024
Merged

Use Publisher Everywhere #3803

merged 7 commits into from
Jul 22, 2024

Conversation

JamesMurkin
Copy link
Contributor

Use the pulsarutils.Publisher everywhere we publish eventsequences

Motivations for this are:

  • Same code used to publish to pulsar used in all places
  • Better testing on that piece of code
  • Less work if we need to work on publisher in future (only 1 place to update)

This PR is largely built off of #3583

Use the pulsarutils.Publisher everywhere we publish eventsequences

Motivations for this are:
 - Same code used to publish to pulsar used in all places
 - Better testing on that piece of code
 - Less work if we need to work on publisher in future (only 1 place to update)

Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
@JamesMurkin JamesMurkin marked this pull request as ready for review July 19, 2024 16:08
@JamesMurkin JamesMurkin changed the title Use Publisher Eveywhere Use Publisher Everywhere Jul 19, 2024
Signed-off-by: JamesMurkin <[email protected]>
@JamesMurkin JamesMurkin merged commit 7d4ed88 into master Jul 22, 2024
20 checks passed
@JamesMurkin JamesMurkin deleted the same_publisher_everywhere branch July 22, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants