Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use A Publisher Everwhere #3583

Closed
wants to merge 11 commits into from
Closed

Use A Publisher Everwhere #3583

wants to merge 11 commits into from

Conversation

d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented May 13, 2024

Update everywhere that needs to publish Pulsar messages to use a Publisher interface. This means:

  • We're a bit more decoupled from publishes
  • We publish all event messages in a consistent manner. This means we now have a place where we can e.g. log a warning if event messages don't have an optional field filled in.

d80tb7 and others added 11 commits May 13, 2024 18:34
@d80tb7
wip
4168e8a 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
wip
6e494fa 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
make everything use a publisher
993482f 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
merge master
84f8597 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
merge master
03294d1 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
fix merge conflict
4f92b14 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
Merge branch 'master' into f/chrisma/publisher-everywhere
e9432aa
@d80tb7
Merge branch 'master' of github.com:armadaproject/armada into f/chris…
fddeafb 
…ma/publisher-everywhere
@d80tb7
fix test
570d98f 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
fix generate
f6ad10c 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
Merge branch 'master' into f/chrisma/publisher-everywhere
d8ab975
@JamesMurkin JamesMurkin mentioned this pull request Jul 19, 2024
Merged
@JamesMurkin
Copy link
Contributor

Replaced by #3803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d80tb7 @JamesMurkin