Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments #652

Merged
merged 1 commit into from
May 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ec/src/models/short_weierstrass/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ pub trait SWCurveConfig: super::CurveConfig {
/// Check if the provided curve point is in the prime-order subgroup.
///
/// The default implementation multiplies `item` by the order `r` of the
/// prime-order subgroup, and checks if the result is one.
/// prime-order subgroup, and checks if the result is zero.
/// Implementors can choose to override this default impl
/// if the given curve has faster methods
/// for performing this check (for example, via leveraging curve
Expand Down
4 changes: 2 additions & 2 deletions ec/src/models/short_weierstrass/serialization_flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ use ark_serialize::Flags;
/// The default flags (empty) should not change the binary representation.
#[derive(Clone, Copy, PartialEq, Eq, Debug)]
pub enum SWFlags {
/// Represents a point with positive y-coordinate by setting the MSB to 1.
/// Represents a point with positive y-coordinate by setting all bits to 0.
YIsPositive = 0,
/// Represents the point at infinity by setting the setting the last-but-one bit to 1.
PointAtInfinity = 1 << 6,
/// Represents a point with negative y-coordinate by setting all bits to 0.
/// Represents a point with negative y-coordinate by setting the MSB to 1.
YIsNegative = 1 << 7,
}

Expand Down