Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments #652

Merged
merged 1 commit into from
May 26, 2023
Merged

Fix comments #652

merged 1 commit into from
May 26, 2023

Conversation

hujw77
Copy link
Contributor

@hujw77 hujw77 commented May 26, 2023

Description

Fix commnets

closes: #648


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@hujw77 hujw77 requested review from a team as code owners May 26, 2023 05:59
@hujw77 hujw77 requested review from Pratyush, mmagician and weikengchen and removed request for a team May 26, 2023 05:59
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ValarDragon ValarDragon self-requested a review May 26, 2023 16:47
@Pratyush Pratyush merged commit c015ea3 into arkworks-rs:master May 26, 2023
aleasims pushed a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
aleasims added a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between code and documentation
3 participants