Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many country & province history files had mixed (CR/LF together with LF)
or inappropriate (i.e. lone CR) line endings. With this change all those
files use consistent line endings.
Something along the lines of
git diff --ignore-space-at-eol Development
is suggested to review the changes: it’ll take care of theCR/LF noise by hiding all of it. This also goes some way into
demonstrating that most changes are intended conversions to native line
endings.
This should only leave lone CR changes in the diffs to review. (Unless
you are a time traveller using classic Mac OS I suppose. Hi!)
The province changes were tested (i.e. borders and some of the province data looks right once in the game). I also looked at the child labour and political rights of a couple countries to make sure they were correct, as there is a CR line ending change around these in some of the country files.