Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add source repos to fields inherited from global projects #5417

Merged
merged 4 commits into from
Feb 5, 2021
Merged

feat: add source repos to fields inherited from global projects #5417

merged 4 commits into from
Feb 5, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Feb 5, 2021 •
edited
Loading

Signed-off-by: Remington Breeze [email protected]

Fixes #3045

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@rbreeze rbreeze added this to the v1.9 milestone Feb 5, 2021
@rbreeze rbreeze requested a review from mayzhang2000 February 5, 2021 00:52
@rbreeze rbreeze added the only-needs-a-rubber-stamp The author thinks this is low-risk & low-impact, so suggest a cursory review label Feb 5, 2021
@rbreeze rbreeze requested a review from alexmt February 5, 2021 00:52
@jessesuen
Copy link
Member

I think we need to also update the documentation

@jessesuen
Copy link
Member

Also, while we are at it, we might as well support clusters.

@rbreeze rbreeze requested a review from jessesuen February 5, 2021 17:31
alexmt
alexmt approved these changes Feb 5, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbreeze rbreeze merged commit 3c3325f into argoproj:master Feb 5, 2021
@rbreeze rbreeze deleted the globalproj-repo branch February 5, 2021 19:48
@zoetrope zoetrope mentioned this pull request Feb 8, 2021
Closed
4 tasks
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
@rbreeze @Shubhama19
feat: add source repos to fields inherited from global projects (argo…
e6a327f 
…proj#5417)

Signed-off-by: Remington Breeze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

@mayzhang2000 mayzhang2000 Awaiting requested review from mayzhang2000

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees
No one assigned
Labels
only-needs-a-rubber-stamp The author thinks this is low-risk & low-impact, so suggest a cursory review
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Restrict Application.spec.project by Application.spec.source.repoURL
3 participants
@rbreeze @jessesuen @alexmt