Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vapplication.kb.io validation from neco-admission #1391

Closed
4 tasks
zoetrope opened this issue Feb 8, 2021 · 0 comments
Closed
4 tasks

Remove vapplication.kb.io validation from neco-admission #1391

zoetrope opened this issue Feb 8, 2021 · 0 comments

Comments

@zoetrope
Copy link
Member

zoetrope commented Feb 8, 2021

What

In order to prevent tenants from accessing arbitrary repositories, we developed neco-admission to validate app.spec.project according to app.spec.source.repoURL.
https://github.com/cybozu/neco-containers/blob/main/admission/docs/configuration.md#argocdapplicationvalidator

We would like to remove this neco-admission validation and instead use ArgoCD's standard features to resolve the problem.

How

Conduct a PoC and consider how to implement.
ref. argoproj/argo-cd#5417

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@zoetrope zoetrope closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant