Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Changed docs for Helm to clarify the location of values files. #4417

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

SayakMukhopadhyay
Copy link
Contributor

@SayakMukhopadhyay SayakMukhopadhyay commented Sep 24, 2020

Also did a grammar pass on that particular file. Closes #4406

@codecov-commenter
Copy link

Codecov Report

Merging #4417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4417   +/-   ##
=======================================
  Coverage   41.18%   41.18%           
=======================================
  Files         122      122           
  Lines       16584    16584           
=======================================
  Hits         6830     6830           
  Misses       8772     8772           
  Partials      982      982           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f5043...a2d4426. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, much appreciated!

LGTM.

@jannfis jannfis merged commit c1ee89b into argoproj:master Sep 24, 2020
@SayakMukhopadhyay SayakMukhopadhyay deleted the docs-helm-values-file branch September 24, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Helm user guide incorrectly claims that values files needs to be in the same or subdirectory of chart
3 participants