Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Helm user guide incorrectly claims that values files needs to be in the same or subdirectory of chart #4406

Closed
SayakMukhopadhyay opened this issue Sep 23, 2020 · 2 comments · Fixed by #4417
Labels
bug Something isn't working

Comments

@SayakMukhopadhyay
Copy link
Contributor

The note attached to the helm user guide claims the following

Values files must be on the same directory or a subdirectory of the Helm application

I have tried keeping the values.yaml file outside the chart directory and I can still access it using relative path. Here' an example Application that works

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: my-stuff
  namespace: argocd
  finalizers:
    - resources-finalizer.argocd.argoproj.io
spec:
  destination:
    namespace: stuff
    server: https://kubernetes.default.svc
  project: default
  source:
    path: charts/my-stuff
    repoURL: [email protected]:my-repo/my-charts.git
    targetRevision: HEAD
    helm:
      releaseName: my-stuff
      valueFiles:
        - ../../valuesFiles/my-stuff/values.yaml

As you can see that the values.yaml file is in a seperate root directory of the repo and using a relative path works. Maybe the note should be updated with this information.

I can create a PR for the same if its fine.

@SayakMukhopadhyay SayakMukhopadhyay added the bug Something isn't working label Sep 23, 2020
@alexmt
Copy link
Collaborator

alexmt commented Sep 23, 2020

Thank you @SayakMukhopadhyay / PR is welcome.

@jessesuen
Copy link
Member

I believe we enforce that it should be in the same repo (for security reasons), you're right that it doesn't need to be under same path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants