Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWM Dimmer multi-press and ledmask support #9584

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add PWM Dimmer multi-press and ledmask support #9584

merged 1 commit into from
Oct 20, 2020

Conversation

pcdiem
Copy link
Contributor

@pcdiem pcdiem commented Oct 20, 2020

Description:

Restructure PWM Dimmer to support multi-press buttons.

Make PWM Dimmer function button hold time a constant .5 seconds allowing SetOption32 value to be used for determining hold time for non-PWM Dimmer functions.

Add support for ledmask command to specify which LEDs are used to indicate the brightness. LEDs cooresponding to unset bits in ledmask can be used for other purposes.

Add support for dimmer switches with no local load (no relay and no PWM - all buttons control remote devices).

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.3
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 74d25bd into arendst:development Oct 20, 2020
arendst added a commit that referenced this pull request Oct 20, 2020
- Support for EZO RTD sensors by Christopher Tremblay (#9585)
- On ZigbeeBridge support for glowing led when permit join is active (#9581)
- Support for PWM Dimmer multi-press and ledmask (#9584)
@ascillato2 ascillato2 added the hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants