Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glowing led when permit join #9581

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Glowing led when permit join #9581

merged 1 commit into from
Oct 19, 2020

Conversation

s-hadinger
Copy link
Collaborator

Description:

Make the blue LED glow when Pairing mode is enabled.

Also fixes an issue with auto-responder, it was not sending the correct transaction id, so the device requesting an attribute would ignore the answer (SHP13).

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.3
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 32648da into arendst:development Oct 19, 2020
arendst added a commit that referenced this pull request Oct 20, 2020
@arendst
Add Breaking Changed to Release Notes
500fb14 
- Support for EZO RTD sensors by Christopher Tremblay (#9585)
- On ZigbeeBridge support for glowing led when permit join is active (#9581)
- Support for PWM Dimmer multi-press and ledmask (#9584)
@ascillato2 ascillato2 added the hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge label Oct 21, 2020
@s-hadinger s-hadinger deleted the zigbee_oct_19 branch January 6, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-hadinger @ascillato2