-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: crash when using tjpegd and LVGL #21544
Conversation
Thanks. We need to keep track of this change otherwise it will be overwritten by the next LVGL update. Do you think of any other option in librariy.json to achieve the same result without changing source code ? |
Maybe … ESP_ROM_HAS_JPEG_DECODE Could be a candidate. if this works, the best way would be to use this instead and upstream the change to LVGL. |
I was thinking about adding in [...]
"build": {
"includeDir": ".",
"flags": [ "-I$PROJECT_DIR/tasmota/lvgl_berry" ],
"srcFilter": ["-<libs/tjpgd/**>"]
},
[...] I haven't tested at all, but that was the spirit of removing a directory from the build chain. |
Yep, suggested solution should work fine. https://docs.platformio.org/en/latest/projectconf/sections/env/options/build/build_src_filter.html#projectconf-build-src-filter |
* Berry coc parser keeps order of variables (arendst#21542) * Bugfix: crash when using tjpegd and LVGL (arendst#21544) * prevent crashes when using tjpegd in other places in Tasmota * do not use external tjpegd in Tasmota * Update changelogs * SML: Allow larger offset when using x to ignore bytes (arendst#21535) * Allow larger offset when using x to ignore bytes STW Klagenfurt sends 355 bytes, and the interesting values starts somewhere at position 304. Therefor we need to set a larger uint range to allow more than 255 bytes to ignore. * Update xsns_53_sml.ino --------- Co-authored-by: Theo Arends <[email protected]> * Change GPIOViewer from v1.5.3 to v1.5.4 (No functional change) * Fix GPIO16 as Transmit enable pin (arendst#21269) * Support Levoit Core200s (WIP, Feedback requested) (arendst#21502) * Support Levoit Core 200S Add berry script to support Levoit Core 200S (and possibly other too since levoit offers multiple similar devices) * Core200S: fix comments * forgotten safety check (arendst#21549) * Bump v14.1.0.1 * Berry bytes solidification (arendst#21558) * Berry prepare for bytes() solidification * Berry solidification of bytes objects * Berry solidification of `bytes` instances * Matter support for Air Quality sensors (arendst#21559) * Add default value for `SetOption151` (arendst#21560) * Update changelogs * Remove GPIO_I2S_BCLK_IN, GPIO_I2S_WS_IN * add uTouch settings * uTouch for m5core2 * Berry `input()` returns empty string and does not crash (arendst#21565) --------- Co-authored-by: s-hadinger <[email protected]> Co-authored-by: Christian Baars <[email protected]> Co-authored-by: Theo Arends <[email protected]> Co-authored-by: Andreas Doppelhofer <[email protected]> Co-authored-by: blenk92 <[email protected]> Co-authored-by: Christian Baars <[email protected]> Co-authored-by: Jason2866 <[email protected]>
Description:
Tasmotas Arduino framework does include tjpegd in ROM and it clashes with the externally added library.
The external library would be compiled in with LVGL activated in the build environment and lead to repeatable crashes when accessing functions of tjpegd in other code parts.
This will also shrink the firmware binary in these cases.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass