Berry coc parser keeps order of variables #21542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason2866
added a commit
to Jason2866/Tasmota
that referenced
this pull request
Jun 5, 2024
* Berry coc parser keeps order of variables (arendst#21542) * Bugfix: crash when using tjpegd and LVGL (arendst#21544) * prevent crashes when using tjpegd in other places in Tasmota * do not use external tjpegd in Tasmota * Update changelogs * SML: Allow larger offset when using x to ignore bytes (arendst#21535) * Allow larger offset when using x to ignore bytes STW Klagenfurt sends 355 bytes, and the interesting values starts somewhere at position 304. Therefor we need to set a larger uint range to allow more than 255 bytes to ignore. * Update xsns_53_sml.ino --------- Co-authored-by: Theo Arends <[email protected]> * Change GPIOViewer from v1.5.3 to v1.5.4 (No functional change) * Fix GPIO16 as Transmit enable pin (arendst#21269) * Support Levoit Core200s (WIP, Feedback requested) (arendst#21502) * Support Levoit Core 200S Add berry script to support Levoit Core 200S (and possibly other too since levoit offers multiple similar devices) * Core200S: fix comments * forgotten safety check (arendst#21549) * Bump v14.1.0.1 * Berry bytes solidification (arendst#21558) * Berry prepare for bytes() solidification * Berry solidification of bytes objects * Berry solidification of `bytes` instances * Matter support for Air Quality sensors (arendst#21559) * Add default value for `SetOption151` (arendst#21560) * Update changelogs * Remove GPIO_I2S_BCLK_IN, GPIO_I2S_WS_IN * add uTouch settings * uTouch for m5core2 * Berry `input()` returns empty string and does not crash (arendst#21565) --------- Co-authored-by: s-hadinger <[email protected]> Co-authored-by: Christian Baars <[email protected]> Co-authored-by: Theo Arends <[email protected]> Co-authored-by: Andreas Doppelhofer <[email protected]> Co-authored-by: blenk92 <[email protected]> Co-authored-by: Christian Baars <[email protected]> Co-authored-by: Jason2866 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changed Berry python
cocparser to keep the variable order in a class, instead of a pseudo-random order which was a side-effect of Berry key hashing. Class made by the normal parser do respect the variable order.This has no direct functional impact, but will be necessary for a future feature of solidification of
bytesobject. And it's cleaner this way.Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass