Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC-Switch Protocol Disable via Console #10063

Merged
merged 3 commits into from
Dec 6, 2020
Merged

RC-Switch Protocol Disable via Console #10063

merged 3 commits into from
Dec 6, 2020

Conversation

BBBits
Copy link
Contributor

@BBBits BBBits commented Dec 5, 2020

Description:

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.7
  • The code change is tested and works on Tasmota core ESP32 V.1.0.4.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass
Hope there is a spare 64bit space in settings.
still has the ifdef BAZMODS tags in the code.
created the uint64_t_t because printf didn't play nice with 64bit and was easy way to split it up.

Removed all code changes out i18n.h  & support_command.ino
@BBBits
Copy link
Contributor Author

BBBits commented Dec 5, 2020

Hopefully the only changes left are resolving an actual entry in settings and the routines associated that and saving settings.
First time doing a PR so if I screwed up please mention so I can learn .

@arendst
Copy link
Owner

arendst commented Dec 6, 2020

I will cleanup after the merge. Thx.

@arendst arendst merged commit 6a3ef27 into arendst:development Dec 6, 2020
arendst added a commit that referenced this pull request Dec 6, 2020
Add command ``RfProtocol`` to control RcSwitch receive protocols by BBBits (#10063)
@curzon01
Copy link
Contributor

curzon01 commented Dec 7, 2020

@BBBits want to update the decode-config tool and wondering myself: What are the possible syntax of the new command 'RfProtocol'?

@BBBits
Copy link
Contributor Author

BBBits commented Dec 7, 2020 via email

@Jason2866
Copy link
Collaborator

@BBBits Please can you add the info to the docu?

@bilogic
Copy link

bilogic commented Dec 14, 2020

@BBBits Thanks for this, it helped me!

I was wondering if there is anyway to support 2 RF TX and RX.

My ultimate aim is to point multiple interrupts to 1 single ISR, however, it greatly reduced the number of times the ISR was called, i.e. if I pressed my remote 433Mhz 10 times, the 433Mhz ISR only triggers 2 or 3 times, likewise for my 315Mhz.

https://stackoverflow.com/questions/64305327/attaching-multiple-interrupts-to-single-isr-function-in-arduino-esp8266

See my commit that uses 2 buffers bilogic/rc-switch@70320fb

@BBBits
Copy link
Contributor Author

BBBits commented Dec 14, 2020

I'll have a look when I get some time.
I suspect the only way to get it reliable would be to do Less in the IRQ.
currently I use 2 esp's  .
prior to tasmota , I sampled 2 pins in one 100uS timer instead of pin change irq .
The code was done for the PIC18F97J60 .
I was only looking for 2 protocols  X10 (433)  & PT2262(315)
so the code was basic in comparison to RC-Switch

@bilogic
Copy link

bilogic commented Dec 14, 2020

I did a quick search for multiple receivers and found this https://github.com/BCsabaEngine/RCSwitch
I'm going to give it a shot later in the day.

@BBBits
Copy link
Contributor Author

BBBits commented Dec 14, 2020

Hi Jason,
I really would like to but am struggling with mkdocs .
I haven't got the extensions or plugins install figured out .....
I'm a sad old windows guy ..

@BBBits
Copy link
Contributor Author

BBBits commented Dec 14, 2020

prob not the right place to ask but can someone point me to a place with instructions that work for mkdocs in windows
ERROR - Config value: 'plugins'. Error: The "alternate-link" plugin is not installed

tried here https://github.com/cmitu/mkdocs-altlink-plugin but no go

@bilogic
Copy link

bilogic commented Dec 14, 2020

@BBBits was there an issue you were trying to solve with this PR?

I'm asking as I tested https://github.com/BCsabaEngine/RCSwitch and found it to be fast and accurate, not to mention being able to support multiple frequencies without the need for multiple ISRs. I plan to make a PR into tasmota and wanted to understand your motivation first.

Thank you.

@BBBits
Copy link
Contributor Author

BBBits commented Dec 14, 2020

OOPS
replied to wrong email .
just did a PR for another repo
not treading on toes here.
interesting the code you found .
it would probably work in a timer int .

also have finally got mkdocs running .
now gotta figure the syntax

@BBBits
Copy link
Contributor Author

BBBits commented Dec 14, 2020

I am in lala land.
THIS PR was to resolve random protocols from flooding the logs .
I live in a noisy world

@BBBits
Copy link
Contributor Author

BBBits commented Dec 14, 2020

Also wanted to keep the noise down because I blindly send the received RF codes out with KNX
having a minimum Bits setting could also do the job .

@bilogic
Copy link

bilogic commented Dec 14, 2020

Ok, understood. I will bear them in mind. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants