Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple frequencies for RFRecv, rc-switch #10134

Closed
bilogic opened this issue Dec 14, 2020 · 6 comments
Closed

Multiple frequencies for RFRecv, rc-switch #10134

bilogic opened this issue Dec 14, 2020 · 6 comments
Labels
requested feature (hold over) Result - Feature that will not be added soon (out of scope)

Comments

@bilogic
Copy link

bilogic commented Dec 14, 2020

Have you looked for this feature in other issues and in the docs?
Yes

Is your feature request related to a problem? Please describe.
RFRecv supports only 1 receiver per microprocessor today, this makes it impossible to support multiple frequencies at the same time.

Describe the solution you'd like
Make RFRecv support multiple receivers, e.g. 1 x 315Mhz and 1x 433Mhz together

Describe alternatives you've considered
Using 2 microprocessors, which is quite a waste.

Additional context
There is a tested working proof of concept here https://github.com/BCsabaEngine/RCSwitch and I'm prepared to write the PR code, but need some help understanding Tasmota code

1. I'm reviewing https://github.com/arendst/Tasmota/blob/development/tasmota/xdrv_17_rcswitch.ino and have some trouble understanding how to work out which pin RFRecv is attached to.

I may have more questions along the way. Thank you.

(Please, remember to close the issue when the problem has been addressed)

@ascillato2 ascillato2 added the feature request (devs?) Action - awaiting response from developers label Dec 14, 2020
@bilogic
Copy link
Author

bilogic commented Dec 14, 2020

Been reading https://tasmota.github.io/docs/API/#driver-sensor-energy-and-light-callback-ids but unsure how to know which pins have been assigned RFRecv. Any idea?

Thank you.

@arendst
Copy link
Owner

arendst commented Dec 14, 2020

RFRecv supports only 1 receiver per microprocessor today, this makes it impossible to support multiple frequencies at the same time.

How about adding another wemos with another type of receiver? This is just a hardware change (using 434MHz or ie. 858MHz). I use it too on different devices.

Adding more interfaces to this software is more like a challenge and a can-do solution than adding anything usefull to it. It over complicates selecting user input and I feel it is of no use.

As for me, don't waste your time screwing up the code.

@ascillato2 ascillato2 added requested feature (hold over) Result - Feature that will not be added soon (out of scope) and removed feature request (devs?) Action - awaiting response from developers labels Dec 14, 2020
@bilogic
Copy link
Author

bilogic commented Dec 14, 2020

@arendst Yea, I'm starting to understand the code. I just figured out the part about finding all pins that are RFRecv. Sorry, I'm very new to Tasmota.

  1. I assumed that it was possible to have multiple WS2812B on different GPIOs, is this correct?
  2. I wanted to do the same for RFRecv
  3. Do you mean it is not possible to have 2 x RFRecv?

@ascillato
Copy link
Contributor

I assumed that it was possible to have multiple WS2812B on different GPIOs, is this correct?

Sorry. No. Only one led strip is supported.

I wanted to do the same for RFRecv

Sorry, won't be added for now. #10134 (comment)

@bilogic
Copy link
Author

bilogic commented Dec 14, 2020

Guys, it's done! I have RFRecv on D3 and D7 on my tasmota-sensor.bin in less than 20 lines of code changes. And everything is backward compatible!

The changes I made are scalable above 2 pins. However, I tested only 2 pins based on https://github.com/BCsabaEngine/RCSwitch, but his/her claim was it can go beyond 2 pins.

Please do have a look at my repo/PR shortly. Thank you.

@bilogic
Copy link
Author

bilogic commented Dec 15, 2020

Hi,

This was what I did to allow multiple definitions of RFRecv
bilogic@432f253

Is this something you guys will pull? If yes, I will merge my RCSwitch.cpp with the changes from #10063

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested feature (hold over) Result - Feature that will not be added soon (out of scope)
Projects
None yet
Development

No branches or pull requests

4 participants