Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf_switch nSeparationLimit #10840

Closed
6 of 14 tasks
PepeTheFroggie opened this issue Feb 5, 2021 · 6 comments
Closed
6 of 14 tasks

rf_switch nSeparationLimit #10840

PepeTheFroggie opened this issue Feb 5, 2021 · 6 comments
Labels
troubleshooting Type - Troubleshooting

Comments

@PepeTheFroggie
Copy link

PepeTheFroggie commented Feb 5, 2021

PROBLEM DESCRIPTION

A clear and concise description of what the problem is.

rf_switch receive of protocol 4 data not working

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

  • Read the Contributing Guide and Policy and the Code of Conduct
  • Searched the problem in issues
  • Searched the problem in discussions
  • Searched the problem in the docs
  • Searched the problem in the chat
  • Device used (e.g., Sonoff Basic): _____
  • Tasmota binary firmware version number used: _____
    • Pre-compiled
    • Self-compiled
  • Flashing tools used: _____
  • Provide the output of command: Backlog Template; Module; GPIO 255:
  Configuration output here:

  • If using rules, provide the output of this command: Backlog Rule1; Rule2; Rule3:
  Rules output here:

  • Provide the output of this command: Status 0:
  STATUS 0 output here:

  • Set weblog to 4 and then, when you experience your issue, provide the output of the Console log:
  Console output here:

TO REPRODUCE

Steps to reproduce the behavior:

try to receive protocol 4 433mhz signal

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.

i expect the protocol 4 rf message to show up like the protocol 1 does

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

need to change file tasmota/lib/lib_rf/src/RCSwitch.cpp
item nSeparationLimit to 2000 to fix it

(Please, remember to close the issue when the problem has been addressed)

@ascillato
Copy link
Contributor

Hi, if you have found already the solution, please help us and provide a pull request. Thanks

@ascillato2 ascillato2 added the troubleshooting Type - Troubleshooting label Feb 5, 2021
@arendst
Copy link
Owner

arendst commented Feb 5, 2021

With this change what will be the impact for other protocols?

@Jason2866
Copy link
Collaborator

Change will have side effects for other protocols. From driver code

// separationLimit: minimum microseconds between received codes, closer codes are ignored.
// according to discussion on issue #14 it might be more suitable to set the separation
// limit to the same time as the 'low' part of the sync signal for the current protocol.
// should be set to the minimum value of pulselength * the sync signal

@PepeTheFroggie
Copy link
Author

PepeTheFroggie commented Feb 6, 2021

A messup in RFsend, tx part:
In the RFsend command the "pulse" variable should NOT be set to default if not specified. "protocol" already contains the correct pulselen.

The tasmota rcswitch receive differs a lot from the original at https://github.com/sui77/rc-switch/blob/master/RCSwitch.cpp.
While i understand whats wrong with the original i do not really understand the new stuff.
I personally would prefer a simpler code, but one able to read my protocol4 PIR down the driveway.

@Jason2866
Copy link
Collaborator

Jason2866 commented Feb 6, 2021

You have noticed the command RfProtocol ?
Disabling the not needed protocols enhances the reliablity of the protocol you want to use.
See #10063 (comment)

@PepeTheFroggie
Copy link
Author

No i was not aware of RfProtocol.
But i think it wont change nSeparationLimit on receive and it wont stop overwriting pulselen with protocol1 default on send.

I will close this and reopen the pulselen thing in discussion.

The nSeparationLimit thing needs a deeper examination, will reopen in discussion if i get a better workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
troubleshooting Type - Troubleshooting
Projects
None yet
Development

No branches or pull requests

5 participants