Fix HandleFieldsGroups trait #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ories which extend ModuleRepository.
m4n1ok
added a commit
to m4n1ok/twill
that referenced
this pull request
Nov 14, 2019
* 1.2: Add style for subscript into wysiwyg (area17#450) Add a default value for `$fieldsGroups` to prevent error from repositories which extend ModuleRepository. (area17#452) fixed the http & https issue from APP URL (area17#431) Add a feature to group fields in a JSON column (area17#410) Replace bcrypt() with Hash::make in CreateSuperAdmin command (area17#445) Fixed the issue that 'delete' => true not working in indexOptions, refs area17#289 (area17#446) Fix « Handle Repeater » feature compatibility with Laravel 5.6 (area17#449) Revert "Add quotes when populating store from form field (area17#416)" Fix media and file libraries upload endpoint logic Properly support fileupload for Azure (area17#443) Invert sorting order in ModuleRepository. Support azure storage (area17#424)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #410, there are some regressions into Twill repositories which extend
ModuleRepository.If
$fieldsGroupsisn't define some repositories will break.I added a default value for
$fieldsGroupsintoModuleRepository.