Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the http & https issue from APP URL #431

Merged
merged 1 commit into from
Nov 12, 2019
Merged

fixed the http & https issue from APP URL #431

merged 1 commit into from
Nov 12, 2019

Conversation

imknight
Copy link
Contributor

original example for Laravel on APP_URL is with Http, this always creates url conflict on twill

@ifox ifox merged commit abb1509 into area17:1.2 Nov 12, 2019
m4n1ok added a commit to m4n1ok/twill that referenced this pull request Nov 14, 2019
@m4n1ok
Merge branch '1.2'
a9f297d 
* 1.2:
  Add style for subscript into wysiwyg (area17#450)
  Add a default value for `$fieldsGroups` to prevent error from repositories which extend ModuleRepository. (area17#452)
  fixed the http & https issue from APP URL (area17#431)
  Add a feature to group fields in a JSON column (area17#410)
  Replace bcrypt() with Hash::make in CreateSuperAdmin command (area17#445)
  Fixed the issue that 'delete' => true not working in indexOptions, refs area17#289 (area17#446)
  Fix « Handle Repeater » feature compatibility with Laravel 5.6 (area17#449)
  Revert "Add quotes when populating store from form field (area17#416)"
  Fix media and file libraries upload endpoint logic
  Properly support fileupload for Azure (area17#443)
  Invert sorting order in ModuleRepository.
  Support azure storage (area17#424)
@flkrnr
Copy link

flkrnr commented Jan 24, 2020

I think with this solution you encounter a problem when using a reverse proxy. Most reverse proxies (like traefik or any cloud service) send a http request to the application which will result in an url beginning with the http scheme even though the user originally requested over https

@trueChazza
Copy link

I think with this solution you encounter a problem when using a reverse proxy. Most reverse proxies (like traefik or any cloud service) send a http request to the application which will result in an url beginning with the http scheme even though the user originally requested over https

Any way to fix this?

For context, I am running traefik which does result in all urls beginning with http.
Browser will not submit anything to insecure endpoints over secure connection.

@imknight
Copy link
Contributor Author

this has been merge, pull the latest and see if you still having problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imknight @flkrnr @trueChazza @ifox