-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-4754: Uploader/Downloader #1415
Merged
thiagocarvalhodev
merged 92 commits into
dev
from
PE-4754-address-code-review-comments-on-uploader-downloader-implementations
Oct 26, 2023
Merged
Changes from all commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
a19db07
refactor: add unawaited method
thiagocarvalhodev 66621fc
Update ardrive_uploader.dart
thiagocarvalhodev c60dc5f
Update data_bundler.dart
thiagocarvalhodev 914383c
refactor(UploadTask)
thiagocarvalhodev 138ecbc
Update upload_controller.dart
thiagocarvalhodev c5b5521
Update data_bundler.dart
thiagocarvalhodev 2e305fe
Update data_bundler.dart
thiagocarvalhodev 7fb57ca
Merge branch 'PE-4754-address-code-review-comments-on-uploader-downlo…
thiagocarvalhodev d1a6970
refactor(UploadItem): renames the implementations for the UploadItem
thiagocarvalhodev 68a784e
refactor(UploadController)
thiagocarvalhodev fb2105a
refactor(base2size)
thiagocarvalhodev 07a767e
refactor(upload progress)
thiagocarvalhodev 15f918b
refactor(streamed upload)
thiagocarvalhodev ab8816f
Update main.dart
thiagocarvalhodev 90dae32
Update authenticate.dart
thiagocarvalhodev 443f2e0
fix: lint warning
thiagocarvalhodev 64005d1
Update upload_cubit.dart
thiagocarvalhodev 238196e
feat(error handling)
thiagocarvalhodev 3e35082
feat(uploader)
thiagocarvalhodev 523c77d
Update upload_controller.dart
thiagocarvalhodev 4780650
Update upload_form.dart
thiagocarvalhodev 14f0c0b
use fetch client with abort
thiagocarvalhodev 8baaefa
feat(uploader)
thiagocarvalhodev 61bb03c
Update ardrive_uploader.dart
thiagocarvalhodev 9dfdf70
feat(uploader)
thiagocarvalhodev aec969f
feat(uploader)
thiagocarvalhodev ec8ac32
fix(uploader)
thiagocarvalhodev fd4062f
feat(uploader)
thiagocarvalhodev 65cb34b
fix(uploader)
thiagocarvalhodev 7150377
Update crypto.dart
thiagocarvalhodev 568a65c
Update app_info_services.dart
thiagocarvalhodev 47d9b1a
fix: creation of a folder
thiagocarvalhodev 3982133
feat(uploader): makes turbo uploads be marked as not possible when si…
matibat a79f08d
chore(limits): rename method PE-4754
matibat 2481ace
feat(uploader)
thiagocarvalhodev 764bf77
Update limits.dart
thiagocarvalhodev a13990d
Update upload_cubit.dart
thiagocarvalhodev 0c41e0c
Update limits.dart
thiagocarvalhodev 39c5b40
Update upload_form.dart
thiagocarvalhodev 1fa946d
Update upload_form.dart
thiagocarvalhodev 387f84a
Update ardrive_uploader.dart
thiagocarvalhodev 69f8b66
Update d2n_streamed_upload.dart
thiagocarvalhodev 65b6a74
Update data_bundler.dart
thiagocarvalhodev f0f389b
fix(cancel upload)
thiagocarvalhodev 9e1291b
Update d2n_streamed_upload.dart
thiagocarvalhodev a123362
feat(abort upload)
thiagocarvalhodev 959152a
feat(abort upload)
thiagocarvalhodev 601c630
fix(cancel upload)
thiagocarvalhodev eeb8976
Update upload_form.dart
thiagocarvalhodev bdb8027
Merge remote-tracking branch 'origin/PE-4754-revert_the_revert' into …
matibat bf03fde
Update turbo_upload_service_dart_io.dart
thiagocarvalhodev 41823ed
feat(json config): enables new uploader for prod; changes the default…
matibat e265996
Merge pull request #1430 from ardriveapp/PE-4844
matibat b68bea9
fix(cancel upload)
thiagocarvalhodev 42af40e
Update ciphers.dart
thiagocarvalhodev 360b54f
feat(dev tools)
thiagocarvalhodev 7922632
Update side_bar.dart
thiagocarvalhodev b2d43e7
Update side_bar.dart
thiagocarvalhodev 098a313
Update turbo_upload_service_web.dart
thiagocarvalhodev bbac1bb
add wakelock
thiagocarvalhodev 33bdf43
Revert "add wakelock"
thiagocarvalhodev 9e0c84c
Merge pull request #1426 from ardriveapp/PE-4812-cancel-button-fails-…
thiagocarvalhodev a3be366
Merge pull request #1434 from ardriveapp/PE-4856-adds-the-dev-tools-o…
thiagocarvalhodev 83d5ba0
feat(pst package)
thiagocarvalhodev d5fc3ed
fix(donwloads)
thiagocarvalhodev c002919
feat(pst)
thiagocarvalhodev bcbb9ad
feat(pst)
thiagocarvalhodev 07c9c6a
Update cost_calculator.dart
thiagocarvalhodev 9aaf2d2
fix(download pins): dont decrypt the data if it is a pin
thiagocarvalhodev 74e0b16
fix(upload warning)
thiagocarvalhodev 2d9f8fa
fix(downloads)
thiagocarvalhodev 3d394d5
refactor:
thiagocarvalhodev 2445c41
upgrades the ardrive_io
thiagocarvalhodev 49d7028
Merge pull request #1422 from ardriveapp/PE-4754_turbo_upload_possible
thiagocarvalhodev 0c3f991
fix: add limitations warnings
thiagocarvalhodev 687b0db
fix: add warning on download modal
thiagocarvalhodev 7a802d4
feat(downloads)
thiagocarvalhodev 6ecd7fd
fix: lints
thiagocarvalhodev 56a7db4
Revert "fix: lints"
thiagocarvalhodev fad67b1
Revert "feat(downloads)"
thiagocarvalhodev 2e51673
fix: downloads on firefox
thiagocarvalhodev fda00d8
fix lint
thiagocarvalhodev a1cbb70
feat(pst)
thiagocarvalhodev 65c607d
refactor:
thiagocarvalhodev a290213
Update ardrive_contract_oracle.dart
thiagocarvalhodev ded60cc
Merge pull request #1440 from ardriveapp/PE-4876-add-warning-to-uploa…
thiagocarvalhodev 855a946
Merge branch 'PE-4754-address-code-review-comments-on-uploader-downlo…
thiagocarvalhodev 7c71a45
Merge branch 'PE-4754-address-code-review-comments-on-uploader-downlo…
thiagocarvalhodev 1b4f080
Update community_oracle.dart
thiagocarvalhodev ac19f01
Merge pull request #1439 from ardriveapp/PE-4866-implement-a-contract…
thiagocarvalhodev 6667841
Merge pull request #1432 from ardriveapp/PE-4851-change-the-return-ty…
thiagocarvalhodev 097c448
Merge pull request #1438 from ardriveapp/PE-4864-unable-to-download-f…
thiagocarvalhodev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,20 @@ | ||
import 'package:ardrive/utils/data_size.dart'; | ||
import 'package:flutter/foundation.dart'; | ||
import 'package:ardrive_utils/ardrive_utils.dart'; | ||
|
||
final privateFileSizeLimit = const MiB(100000).size; | ||
final privateFileSizeLimit = const GiB(65).size; | ||
|
||
final largeFileUploadSizeThreshold = const MiB(500).size; | ||
|
||
final mobilePrivateFileSizeLimit = const GiB(10).size; | ||
|
||
final publicFileSafeSizeLimit = const GiB(5).size; | ||
final nonChromeBrowserUploadSafeLimitUsingTurbo = const MiB(500).size; | ||
|
||
final bundleSizeLimit = kIsWeb ? webBundleSizeLimit : mobileBundleSizeLimit; | ||
int getBundleSizeLimit(bool isTurbo) => | ||
isTurbo ? turboBundleSizeLimit : d2nBundleSizeLimit; | ||
|
||
final webBundleSizeLimit = const MiB(65000).size; | ||
final mobileBundleSizeLimit = const MiB(65000).size; | ||
final d2nBundleSizeLimit = const GiB(65).size; | ||
final turboBundleSizeLimit = const GiB(2).size; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should these be Gibibytes or Gigabytes? - 65000 MiB != 65 GiB. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be 65GiB. |
||
final mobileBundleSizeLimit = const GiB(65).size; | ||
const maxBundleDataItemCount = 500; | ||
const maxFilesPerBundle = maxBundleDataItemCount ~/ 2; | ||
const maxFilesSizePerBundleUsingTurbo = 1; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the line that will throw here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final revision = entity.toRevisionCompanion(performedAction: revisionPerformedAction);