PE-4754: Uploader/Downloader #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to avoid confusion on waiting of not the _uploadFiles method
renames variable
remove unnecessary for and commented code
|
Visit the preview URL for this PR (updated for commit ac19f01): https://ardrive-web--pr1415-pe-4754-address-code-l0gn9fgj.web.app (expires Thu, 02 Nov 2023 16:41:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
- makes the abstract class public - renames from UploadTask to ARFSUpload task as this task uses the ARFS metadata for the upload - uses the correct version for fetch_client from arweave dart
remove for
use switch case instead of if else statement
use switch case instead of if else statement
…ader-implementations' of github.com:ardriveapp/ardrive-web into PE-4754-address-code-review-comments-on-uploader-downloader-implementations
- removes the unstable methods from the API of the UploadController - comments the retry widget on UploadForm
move file for ardrive_utils and replace all the imports
rename variable
- set the progress unavailable for files larger than 500MiB on the streamed upload class - uses the base2size instead of literal integers
- changes the method used for logging
- updates the task status when the process of bundling fails - improves how we check for finished downloads
- implement the Worker and WorkerPool classes to perform the concurrency - add the cancel option for turbo web with dio and fetch client. Still missing the implementation for dio native.
- implements the cancel functionality - add sendTask to the UploadController API - improves how the folder is uploaded
- improves the feedback for the user when the file is in preparation - adds a new icon to show that the upload is in preparation - fixes d2n issue of not finish the upload after reaching 100% on the upload
- improved the inProgress status update - now every property of UploadTask is immutable - improves the logging of errors
if the download failed don't show the upload in progress without progress text
- use the right limit on turbo - add GCM encryption
- warns the user if the upload is bigger than 500mib and it is uploading for Turbo
thiagocarvalhodev
changed the title
- fixes the download of manifest when using ArDriveDownloader
PE-4808: makes turbo uploads be marked as not possible when size is below the limit
- warn the user if the upload is bigger than 500mib uploading for turbo
- adds the new downloader on the share page
This reverts commit 6ecd7fd.
This reverts commit 7a802d4.
validates if the contract oracles are not null
…d-modal PE-4876: add warning to upload modal
…ader-implementations' into PE-4864-unable-to-download-files-in-safari
…ader-implementations' into PE-4864-unable-to-download-files-in-safari
…-reader-that-reads-our-own-cache PE-4866: implement a contract reader that reads our own cache
…pe-of-the-function-cipher-buffer-impl-to-aes-gcm-instead-of-streaming-cipher PE-4851: fix the `cipherBufferImpl` running in a dart vm
…iles-in-safari PE-4864: fixes: unable to download files in safari
thiagocarvalhodev
deleted the
PE-4754-address-code-review-comments-on-uploader-downloader-implementations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tickets for download/upload were merged into staging before the QA and the total review, so the team could go testing it. We will address all the comments on both PRs in this ticket.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/1p63u2td9iov0