Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-4732: video-preview-doesnt-accept-all-mov-and-mpg-formats #1405

Merged
merged 2 commits into from
Oct 5, 2023
Merged

PE-4732: video-preview-doesnt-accept-all-mov-and-mpg-formats #1405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0d41ef
accept all video mime types and handle format errors showing appropri…
kunstmusik Oct 4, 2023
a740c04
localization
kunstmusik Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/blocs/fs_entry_preview/fs_entry_preview_cubit.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,7 @@ class FsEntryPreviewCubit extends Cubit<FsEntryPreviewState> {
return audioContentTypes
.any((element) => element.contains(fileExtension));
case 'video':
return videoContentTypes
.any((element) => element.contains(fileExtension));
return true;
default:
return false;
}
Expand Down
4 changes: 4 additions & 0 deletions lib/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,6 +833,10 @@
"@fileType": {
"description": "The MIME type of the file"
},
"fileTypeUnsupported": "File type unsupported by browser or operating system",
"@fileTypeUnsupported": {
"description": "Message shown when unable to load media file due to unsupported file format"
},
"fileWasCreatedWithName": "This file was created with the name {fileName}.",
"@fileWasCreatedWithName": {
"description": "File activity (journal): created",
Expand Down
Loading