Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-4732: video-preview-doesnt-accept-all-mov-and-mpg-formats #1405

Conversation

kunstmusik
Copy link
Contributor

@kunstmusik kunstmusik commented Oct 4, 2023

  • Redesigned to accept all video mime types, but show error if format is unsupported by underlying video player

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/5ov25e60c7a2o

@kunstmusik kunstmusik changed the base branch from dev to PE-4583-video-preview-in-app October 4, 2023 21:56
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Visit the preview URL for this PR (updated for commit a740c04):

https://ardrive-web--pr1405-pe-4732-video-previe-8ruj8rbe.web.app

(expires Thu, 12 Oct 2023 14:15:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunstmusik kunstmusik merged commit f12f643 into PE-4583-video-preview-in-app Oct 5, 2023
@kunstmusik kunstmusik deleted the PE-4732-video-preview-doesnt-accept-all-mov-and-mpg-formats branch October 5, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants