Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use caret ranges for tslib #4478

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Use caret ranges for tslib #4478

merged 2 commits into from
Jun 7, 2022

Conversation

biro456
Copy link
Contributor

@biro456 biro456 commented May 23, 2022

Description

The tslib dependency present in several packages is not using a caret range, which usually causes it to be duplicated multiple times in the dependency tree.
This PR changes all packages using it to the ^2.4.0 range.

Related #3695

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The test suite was executed with yarn test to ensure the dependency bump didn't break anything.

Test Environment:

  • OS: Ubuntu 20.04.4 LTS on WSL 2 on Windows 10 19044.1706
  • NodeJS: 18.1.0

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

I didn't create a Changeset to leave the decision for the maintainers.

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2022

🦋 Changeset detected

Latest commit: 55e3481

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@graphql-tools/batch-delegate Patch
@graphql-tools/batch-execute Patch
@graphql-tools/delegate Patch
@graphql-tools/graphql-tag-pluck Patch
graphql-tools Patch
@graphql-tools/import Patch
@graphql-tools/jest-transform Patch
@graphql-tools/links Patch
@graphql-tools/load Patch
@graphql-tools/load-files Patch
@graphql-tools/apollo-engine-loader Patch
@graphql-tools/code-file-loader Patch
@graphql-tools/git-loader Patch
@graphql-tools/github-loader Patch
@graphql-tools/graphql-file-loader Patch
@graphql-tools/json-file-loader Patch
@graphql-tools/module-loader Patch
@graphql-tools/prisma-loader Patch
@graphql-tools/url-loader Patch
@graphql-tools/merge Patch
@graphql-tools/mock Patch
@graphql-tools/node-require Patch
@graphql-tools/optimize Patch
@graphql-tools/relay-operation-optimizer Patch
@graphql-tools/resolvers-composition Patch
@graphql-tools/schema Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/utils Patch
@graphql-tools/webpack-loader Patch
@graphql-tools/wrap Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 23, 2022

@biro456 is attempting to deploy a commit to the The Guild Team on Vercel.

A member of the Team first needs to authorize it.

@ardatan
Copy link
Owner

ardatan commented May 27, 2022

Thanks for the PR! Could you rebase your branch to fix the conflicts and create a changeset using yarn changeset then we can merge and release?

@biro456
Copy link
Contributor Author

biro456 commented May 30, 2022

I've rebased and added a changeset with a patch bump on everything.

@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ❌ Failed (Inspect) Jun 7, 2022 at 2:20PM (UTC)

@ardatan ardatan merged commit 041c5ba into ardatan:master Jun 7, 2022
@biro456 biro456 deleted the use-caret-range-for-tslib branch June 7, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants