Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslib should be a caret dependency #3695

Closed
dzearing opened this issue Oct 13, 2021 · 4 comments
Closed

tslib should be a caret dependency #3695

dzearing opened this issue Oct 13, 2021 · 4 comments

Comments

@dzearing
Copy link

dzearing commented Oct 13, 2021

Describe the bug

Across the various graphql-tools packages, because tslib is a tilde dependency (~2.3.0), newer minor releases of tslib release but applications that consume newer builds are unable to deduplicate them because of the tilde deps in the various graphql-tool packages. The tslib dependency should be a caret (e.g. ^2.3.0)

To Reproduce

Build an app using a newer tslib release (e.g. ^2.3.1), consuming any of the graphql-tools/* package versions that were built with a previous minor (e.g. @graphql-tools/[email protected], which depends on tslib ~2.1.0.) Evaluate lockfile, see dupes of tslib due to tilde dependencies.

Expected behavior

Use caret. In the above example, it would have deduped into 1 installed version (2.3.1.) Newer minor builds should be backwards compatible.

@ardatan
Copy link
Owner

ardatan commented Oct 26, 2021

Available with 173d034

@ardatan ardatan closed this as completed Oct 26, 2021
@biro456
Copy link
Contributor

biro456 commented May 17, 2022

Looking at both @graphql-tools/schema and @graphql-tools/utils in master, the range for tslib is still using tilde:

"tslib": "~2.4.0",

"tslib": "~2.4.0"

@n1ru4l
Copy link
Collaborator

n1ru4l commented May 17, 2022

@biro456 Can you send a PR for updating this?

@biro456
Copy link
Contributor

biro456 commented May 18, 2022

Sure I can.

I checked and most packages are using ~2.4.0, so I'll change them to ^2.4.0.
@graphql-tools/url-loader is using ^2.3.0, so should I change that one too to make it consistent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants