-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tslib should be a caret dependency #3695
Comments
Available with 173d034 |
Looking at both
graphql-tools/packages/utils/package.json Line 38 in cf44715
|
@biro456 Can you send a PR for updating this? |
Sure I can. I checked and most packages are using |
Describe the bug
Across the various graphql-tools packages, because
tslib
is a tilde dependency (~2.3.0
), newer minor releases of tslib release but applications that consume newer builds are unable to deduplicate them because of the tilde deps in the various graphql-tool packages. Thetslib
dependency should be a caret (e.g.^2.3.0
)To Reproduce
Build an app using a newer tslib release (e.g.
^2.3.1
), consuming any of thegraphql-tools/*
package versions that were built with a previous minor (e.g.@graphql-tools/[email protected]
, which depends on tslib~2.1.0
.) Evaluate lockfile, see dupes of tslib due to tilde dependencies.Expected behavior
Use caret. In the above example, it would have deduped into 1 installed version (2.3.1.) Newer minor builds should be backwards compatible.
The text was updated successfully, but these errors were encountered: