Add failing test when import documents with comments #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ardatan
force-pushed
the
master
branch
5 times, most recently
from
ade4e70 to
34c31de
Compare
ardatan
force-pushed
the
master
branch
4 times, most recently
from
b1c69a3 to
a9e6cd1
Compare
ardatan
force-pushed
the
master
branch
2 times, most recently
from
3f6ec05 to
50609df
Compare
ardatan
force-pushed
the
master
branch
2 times, most recently
from
4946aeb to
4be9073
Compare
ardatan
force-pushed
the
master
branch
5 times, most recently
from
d34fb65 to
b8bf584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At this moment when we import documents we lost all comments, I added a failing test to show this unexpected behavior.
Related # graphql-hive/graphql-eslint#504