fix(federation): prevent infinite loop while visiting over the comput…

…ed field types
ardatan · Apr 24, 2024 · 8beb141 · 8beb141
1 parent b07b76d
commit 8beb141
Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/.changeset/unlucky-actors-tease.md b/.changeset/unlucky-actors-tease.md
@@ -0,0 +1,5 @@
+---
+"@graphql-tools/stitch": patch
+---
+
+Prevent infinite loop while visiting over the computed field types
diff --git a/packages/stitch/src/subschemaConfigTransforms/isolateComputedFieldsTransformer.ts b/packages/stitch/src/subschemaConfigTransforms/isolateComputedFieldsTransformer.ts
@@ -227,14 +227,16 @@ type IsolatedSubschemaInput = Exclude<SubschemaConfig, 'merge'> & {
 function filterIsolatedSubschema(subschemaConfig: IsolatedSubschemaInput): SubschemaConfig {
   const rootFields: Record<string, boolean> = {};
   const computedFieldTypes: Record<string, boolean> = {}; // contains types of computed fields that have no root field
-
+  const visitedTypes = new WeakSet<GraphQLNamedOutputType>();
   function listReachableTypesToIsolate(
     subschemaConfig: SubschemaConfig,
     type: GraphQLNamedOutputType,
-    typeNames?: string[],
+    typeNames: string[] = [],
   ) {
-    typeNames = typeNames || [];
-
+    if (visitedTypes.has(type)) {
+      return typeNames;
+    }
+    visitedTypes.add(type);
     if (isScalarType(type)) {
       return typeNames;
     } else if (